Two-step calcination method was adopted to in situ prepare ZnO@g-C3N4 core/shell type photocatalyst. ZnO@g-C3N4 enhances the visible light utilization and exhibits better charge separation and suppressed charge recombination. ZnO@g-C3N4 shows improved photocatalytic activity and high cycling stability under visible-light.